Add margin-block-end to pds-textarea label wrapper#778
Conversation
Add margin-block-end: var(--pine-dimension-2xs) to .pds-textarea__label-wrapper to match the spacing used by .pds-input__label-wrapper for visual consistency across input types. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
package: core
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ee56267. Configure here.
| align-items: center; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| margin-block-end: var(--pine-dimension-2xs); |
There was a problem hiding this comment.
Hidden label still adds spacing
Medium Severity
Adding margin-block-end on .pds-textarea__label-wrapper leaves a gap when hideLabel is true. Unlike pds-input, only the inner span is visually hidden, so the wrapper stays in flow and its new margin still reserves space above the field.
Reviewed by Cursor Bugbot for commit ee56267. Configure here.
There was a problem hiding this comment.
@QuintonJason thank you yes agreed ! I saw this and just haven't had a chance to revisit which is why I didn't merge. Will try and get to it next week 👍
4 participants
Summary
margin-block-end: var(--pine-dimension-2xs)to.pds-textarea__label-wrapper.pds-input__label-wrapperfor visual consistency across input typesTest plan
pds-textareawith label renders with correct bottom margin on label wrapperpds-textareaandpds-inputlabels — should now be consistent🤖 Generated with Claude Code
Note
Low Risk
Cosmetic SCSS only; no logic, data, or API impact.
Overview
Adds
margin-block-end: var(--pine-dimension-2xs)on.pds-textarea__label-wrapperso labeled textareas get the same gap between the label row and the field aspds-input.This is a one-line styling tweak in
pds-textarea.scss; no markup or behavior changes.Reviewed by Cursor Bugbot for commit ee56267. Bugbot is set up for automated code reviews on this repo. Configure here.